Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation prompt for stop/restart app #1437

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

CAFxX
Copy link

@CAFxX CAFxX commented Jan 18, 2018

Description

Add a confirmation prompt for the restart and stop app commands

Motivation and Context

Restart and stop are disruptive operations, in that they cause the application to become unavailable. The CLI prompts for confirmation before executing these operations: UIs should as well.

See #1435

How Has This Been Tested?

Deployed on CF and run against the CF API.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@richard-cox
Copy link
Contributor

Thanks for creating this PR!

I've pushed a fix which should get the PR passed a few blocking issues in travis. It will still fail the e2e tests (due to a known set up issue) however I've run these locally and they look good.

Could you rebase with my commit and then amend your commit message to contain a sign off statement per our contributing doc (to edit a commit messages from history see here).

Once all that is done we should be good to merge

richard-cox and others added 2 commits January 19, 2018 08:50
Signed-off-by: Carlo Alberto Ferraris <cafxx@strayorange.com>
@richard-cox richard-cox merged commit 4886138 into cloudfoundry:master Jan 19, 2018
@CAFxX CAFxX deleted the upstreaming branch January 19, 2018 11:29
@nwmac nwmac added this to the Sprint 22 milestone Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants