Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature french localization #1419

Merged
merged 11 commits into from
Dec 18, 2017
Merged

Add Feature french localization #1419

merged 11 commits into from
Dec 18, 2017

Conversation

hamzahamidi
Copy link
Contributor

@hamzahamidi hamzahamidi commented Dec 13, 2017 •
edited
Loading

Description

Add french support to the project.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@hamzahamidi
Add french to english locales
b6c78bc 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to app-core
02362e2 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to about app
5bf533e 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to app Framework
1cc3943 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to app setup
86ff089 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to app-push
5539145 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to app SSH
ff0e858 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to cloud-foundry
ab88854 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to dashboard
88f9a4b 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to suse-branding
f1a7778 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Add french to user-info
1a6f922 
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
@hamzahamidi
Copy link
Contributor Author

Any ideas why tests fail when trying to log in the console?

@nwmac
Copy link
Contributor

nwmac commented Dec 18, 2017

@hamzahamidi Thanks for this PR - this looks great.

The issue it is failing is because the e2e tests rely on secrets from Travis to access a Cloud Foundry system for performing the tests.

For security reasons, Travis does not make those secrets available when testing PRs from forks.

I'll need to think about this longer term - for now, I will modify the Travis pipeline to skip the e2e tests in this case. For PRs from forks, we will use the following workflow for now:

  • One of the team will review the PR and then run a script to create a branch in the Stratos repo with the changes for that PR (named PR-NNNN)
  • Travis will run against this branch and run all tests
  • If there are failures, we will comment on the PR with a link to the Travis run that failes
  • If everything is okay, we will approve and merge the PR and delete the branch that we created for the e2e tests.

@nwmac
Copy link
Contributor

nwmac commented Dec 18, 2017

This has passed the gate check - see: https://travis-ci.org/SUSE/rmt/builds/318022651

nwmac
nwmac approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 41ca056 into cloudfoundry:master Dec 18, 2017
@hamzahamidi hamzahamidi deleted the feature_french_localization branch December 18, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamzahamidi @nwmac