Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve byte filter #1388

Merged
merged 3 commits into from
Nov 23, 2017
Merged

Improve byte filter #1388

merged 3 commits into from
Nov 23, 2017

Conversation

richard-cox
Copy link
Contributor

  • filter would only show values using the total's units
  • for small used totals this means we'd round down to nothing or misleading values
  • for small used totals now show used as different units than total
  • for example 20MB used of 1GB would show as 0 / 1GB. Now we show 20MB / 1GB

@richard-cox
Imporve the accuracy of the bytes filter
6de695c 
- For large disparity used / total bytes the used value would show 0
- Now, for large disparities show smaller units for used instead of same units as total

Previously... 0 / 1 GB, Now... 20MB / 1GB
@richard-cox
Test fixes, exclude backend from frontend linting
43024a0
@richard-cox richard-cox mentioned this pull request Nov 21, 2017
Closed
1 task
@nwmac nwmac merged commit f2f1348 into master Nov 23, 2017
@nwmac nwmac deleted the improve-byte-filter branch November 23, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac