Add ability to edit a service instance #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
richard-cox
suggested changes
Oct 26, 2017
There was a problem hiding this comment.
- Nit picking ... click edit service, add lots of tags, click update and then click edit service again and the modal consumes the full width before wrapping the tag lines.
- Changes to the instance parameters don't seem to be persisted. Click edit service, click edit in the instance parameters, add valid json, click done (json shown in instance parameters input), click 'update' and then click edit again.
|
@richard-cox I will fix the tags issue - the parameters can not be retrieved - you can only send them in the update - there is no way to get them back from the API - see: https://apidocs.cloudfoundry.org/272/service_instances/retrieve_a_particular_service_instance.html |
richard-cox
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to edit an existing service instance.