Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure UAA settings when deploying UI through helm chart #1315

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Add ability to configure UAA settings when deploying UI through helm chart #1315

merged 2 commits into from
Oct 25, 2017

Conversation

irfanhabib
Copy link
Contributor

No description provided.

@irfanhabib
Copy link
Contributor Author

This passed all tests, I'm setting up a new concourse instance and using this PR to test it.

@irfanhabib
Copy link
Contributor Author

Corresponding unit test was http://bristol-ui-concourse.ngrok.io/builds/1115

nwmac
nwmac approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 9307aad into master Oct 25, 2017
@nwmac nwmac deleted the uaa-helm branch October 25, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanhabib @nwmac