Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate container images to opensuse:42.3 base #1293

Merged
merged 7 commits into from
Oct 25, 2017
Merged

Migrate container images to opensuse:42.3 base #1293

merged 7 commits into from
Oct 25, 2017

Conversation

irfanhabib
Copy link
Contributor

@irfanhabib irfanhabib commented Oct 9, 2017 •
edited
Loading

  • Migrates all containers to a common base
  • Uses a set of intermediate images which can be retargeted to a different base (SLE vs opensuse)

@irfanhabib irfanhabib force-pushed the migrate-to-opensuse branch 3 times, most recently from ec96fd2 to d1253fb Compare October 10, 2017 15:34
nwmac
nwmac suggested changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

deploy/stratos-base-images/Dockerfile.stratos-go-base.tmpl Outdated
@@ -0,0 +1,15 @@
FROM {{BASE_IMAGE}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to Dockerfile.stratos-go-build-base.tmpl

and update dependencies on this name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

deploy/stratos-base-images/Dockerfile.stratos-ui-base.tmpl Outdated
@@ -0,0 +1,8 @@
FROM {{BASE_IMAGE}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to Dockerfile.stratos-ui-build-base.tmpl

and update dependencies on this name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

deploy/stratos-base-images/build-base-images.sh Outdated
BASE_IMAGE=opensuse:42.3
REGISTRY=docker.io
ORGANIZATION=splatform
TAG=dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change tag to 'opensuse'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

nwmac
nwmac approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 99ebba3 into master Oct 25, 2017
@irfanhabib irfanhabib deleted the migrate-to-opensuse branch November 22, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanhabib @nwmac