Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation issues #1247

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Fix translation issues #1247

merged 2 commits into from
Sep 7, 2017

Conversation

richard-cox
Copy link
Contributor

  • Commit button on create app dialog
  • Title of manager users now shows user name again (see individual commit message for more detail)

@richard-cox
Fix the title of the manage users dialog
8652dde 
- When managing a single user the user's name was missing from the title
- Ensure async task dialog also includes translate-values just like detail view
@richard-cox
Fix create app commit button text
186e82b
nwmac
nwmac approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit bec8bd0 into master Sep 7, 2017
@nwmac nwmac deleted the fix-manager-user-dialog-title branch September 7, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac