Show deployment information in app summary for console deployed apps #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Sep 1, 2017
richard-cox
commented
- Information only applies to applications deployed through console
- We already shown information for the basic git source
- This commit adds info for git url and file/archive sources
- Information covers time of deployment and basic source info
…mmary - Information only applies to applications deployed through console - We already had information shown for the basic git source - This commit adds info for git url and file/archive sources - Information covers time of deployment and basic source info
richard-cox
changed the title
nwmac
reviewed
Sep 6, 2017
| @@ -234,6 +236,7 @@ | |||
|
|
|||
| sourceUserInput.fileTransfers = metadata.files; | |||
| metadata.files = metadata.files.length; | |||
| metadata.type = metadata.files === 1 ? 'archive' : 'filefolder'; | |||
There was a problem hiding this comment.
The backend checks the file extension to determine if it is an archive file - rather than basing this on there being only 1 file.
nwmac
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.