Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we wait for $translate onReady before initialising landing page language options #1234

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Ensure we wait for $translate onReady before initialising landing page language options #1234

merged 1 commit into from
Aug 25, 2017

Conversation

richard-cox
Copy link
Contributor

No description provided.

nwmac
nwmac approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 5643f21 into master Aug 25, 2017
@nwmac nwmac deleted the fix-landing-page-localise branch August 25, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac