Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Helm chart to MariaDB #1230

Merged
merged 4 commits into from
Sep 8, 2017
Merged

Migrate Helm chart to MariaDB #1230

merged 4 commits into from
Sep 8, 2017

Conversation

irfanhabib
Copy link
Contributor

NOTE: This depends on #1229

@irfanhabib
Copy link
Contributor Author

@irfanhabib irfanhabib changed the title Update Helm Chart to support mariaDB Migrate Helm chart to MariaDB Aug 24, 2017
@irfanhabib irfanhabib mentioned this pull request Aug 25, 2017
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks

@@ -1,66 +1,81 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function keyword works in sh, and bash isn't available in the postflight container.

execStatement "CREATE DATABASE \"$DB_DATABASE_NAME\";"
echo "Creating user $DB_USER"
if [ "$DATABASE_PROVIDER" = "pgsql" ]; then
execStatement "CREATE USER $DB_USER WITH ENCRYPTED PASSWORD '$PWD';"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB_PASSWD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!


echo "Granting privs for $DB_DATABASE_NAME to $DB_USER"
execStatement "GRANT ALL PRIVILEGES ON DATABASE \"$DB_DATABASE_NAME\" TO $DB_USER;"
DBCONF_KEY=mariadb-k8s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit d335d72 into master Sep 8, 2017
@nwmac nwmac deleted the update-helm branch September 8, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants