Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few service instance bugs #1226

Merged
merged 4 commits into from
Aug 21, 2017
Merged

Fix a few service instance bugs #1226

merged 4 commits into from
Aug 21, 2017

Conversation

richard-cox
Copy link
Contributor

  • Service instances were not shown on application summary tab (have added e2e test)
  • In some circumstances the placeholder for service plans in the add service modal was not localised
  • Automatically select the first service plan in the add service modal

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 0133a53 into master Aug 21, 2017
@nwmac nwmac deleted the fix-add-service-localisation branch August 21, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants