Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminate instance UI #1211

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fix terminate instance UI #1211

merged 1 commit into from
Aug 4, 2017

Conversation

richard-cox
Copy link
Contributor

Couple of issues in the UI following successful termination of an app instance

  • Untranslated string shown in success notification
  • Modal shows failure after successfully terminating (exception during client refresh)

- Bug - Untranslated string shown in terminate instance success notification
- Bug - Terminate modal shows failure after succesfully terminating (exception during client data refresh)
@irfanhabib
Copy link
Contributor

LGTM

@irfanhabib irfanhabib merged commit d96eb1b into master Aug 4, 2017
@irfanhabib irfanhabib deleted the fix-terminate-instance branch November 22, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants