Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SSL certificate handling when deploying through Helm #1210

Merged
merged 8 commits into from
Sep 18, 2017
Merged

Improve SSL certificate handling when deploying through Helm #1210

merged 8 commits into from
Sep 18, 2017

Conversation

irfanhabib
Copy link
Contributor

  1. Removes hard coded certificates
  2. Self signed certificates are generated dynamically when chart is installed (in the preflight job)
  3. User can inject their own trusted certificated by providing the consoleCert and consoleCertKey overrides.

@irfanhabib
Copy link
Contributor Author

(2) Investigate SSL Certs

nwmac
nwmac approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit e402466 into master Sep 18, 2017
@nwmac nwmac deleted the gen-ssl branch September 18, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanhabib @nwmac