Visiting marketplace tab breaks service list #4397
Comments
|
@rschollmeyer Thanks for raising this issue. I've had some trouble recreating this in our I think this might be either a timing issue (maybe some dependent requests have failed to complete in time) or to do with the services shown (different user provider service / service instances visible or number of instances). There might be a way to force the error by starting in the marketplace, moving to service and then seeing a service instance that was created from a service that was not visible in the first page of the marketplace. A workaround might be to put better guarding around the troubled line, but I'd really like to recreate the error before committing to this. |
@richard-cox thanks for your reply. We had this issue with both master branch and the latest version 3.2.1. Furthermore the problem occurred in an environment with 5 services and 6 service instances as well as in an environment with 16 services and 17 service instances.
We checked that and we also that the error when there was only one page in the marketplace. We also discovered that the problem only occurs in the "card view" of the services tab and not in the list view. |
- fixes #4397 - accessing entity via this.serviceInstanceEntity.entity.service_plan.entity.service.entity.service_broker_guid can sometimes fail - fetch service, and thus service broker guid, from store instead - this matches the table way of getting the broker
|
I've created a PR (#4417) that makes how we access the service resource safer (and matches the way we do it in the table view). I was still struggling to reproduce this though, so if you have the chance could you confirm it fixes your issue? We'll be migrating to v3 of the CF API soon. The services endpoints have been reworked and a lot of our components will need updating, including this card. I'll bear this issue in mind when making those changes. |
|
We will try it as soon as possible, I'll let you know if it helps. Thank you so far! |
|
@richard-cox We tried the code from your PR and it really fixed our issue! I'm going to close this and SUSE#399 aswell. Thank you very much! |
…4417) * Fetch service in service instances card via store rather than inline - fixes #4397 - accessing entity via this.serviceInstanceEntity.entity.service_plan.entity.service.entity.service_broker_guid can sometimes fail - fetch service, and thus service broker guid, from store instead - this matches the table way of getting the broker * Fix unit test * Fix & Improve Service Instance Card - ensure async properties have async pipe in html - bind to params rather than properties
Frontend Deployment type
Backend (Jet Stream) Deployment type
Expected behaviour
Services list shows all existing services.
Actual behaviour
When you initially click on the Services tab all services are shown as expected. After clicking the marketplace tab and go back to the Services tab services are sometimes not shown at all (see image and the corresponding error message below). Refreshing the browser on the services page makes the services list works as expected again.
Note: It occurs in both CF Stratos & Suse Stratos.
Steps to reproduce the behavior
Log output covering before error and any error statements
The browser console shows this error multiple times.
Note: We also opened this issue in the Suse Stratos github repository SUSE#399
The text was updated successfully, but these errors were encountered: