Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification and error pages loop when using 'X' #4202

Closed
richard-cox opened this issue Apr 1, 2020 · 0 comments · Fixed by #4203
Closed

Notification and error pages loop when using 'X' #4202

richard-cox opened this issue Apr 1, 2020 · 0 comments · Fixed by #4203
Labels
bug
Milestone
3.1.0

Comments

@richard-cox
Copy link
Contributor

  • Can get stuck in a loop between pages
  • Page --> Events --> Errors --> Events --> Errors --> etc
@richard-cox richard-cox added the bug label Apr 1, 2020
richard-cox added a commit that referenced this issue Apr 1, 2020
@richard-cox
Ensure we don't loop between events and error page
d9bf3d3 
- Previously could get stuck in a loop Page --> Events --> Errors --> Events --> Errors
- We always went to the previous stack in the events and error page
- Now ensure we track where we came from, so when returning to events we break the loop
- fixes #4202
@richard-cox richard-cox mentioned this issue Apr 1, 2020
Merged
@nwmac nwmac added this to the 3.1.0 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Ensure we don't loop between events and error page cloudfoundry/stratos
2 participants
@nwmac @richard-cox