Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Allow custom annotations on Pods #4109

Closed
nwmac opened this issue Jan 29, 2020 · 2 comments
Closed

Helm Chart: Allow custom annotations on Pods #4109

nwmac opened this issue Jan 29, 2020 · 2 comments
Assignees
@nwmac
Labels
P1 Priority 1

Comments

@nwmac
Copy link
Contributor

nwmac commented Jan 29, 2020

In some scenarios we have to define podAnnotations within deployments.

One example is i.e. for backup using velero where we have to add podAnnotations.

We need the Stratos Helm chart to allow custom annotations to be specified.
@nwmac nwmac added the P1 Priority 1 label Jan 29, 2020
@nwmac nwmac self-assigned this Jan 29, 2020
@Martin-Weiss
Copy link

It would be nice if the helm charts values.yaml could align with structure and content (especially parameters available and their documentation) to the way how this is done i.e. in prometheus/grafana/nginx-ingress examples ;-)

A good example might be:

helm repo add stable https://kubernetes-charts.storage.googleapis.com
helm inspect values stable/prometheus --version 9.3.2

@nwmac
Copy link
Contributor Author

nwmac commented Feb 26, 2020

Fixed in 3.0.0

@nwmac nwmac closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwmac nwmac

Labels
P1 Priority 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nwmac @Martin-Weiss