Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Three-dots" menu item is in the wrong place #3076

Closed
mogul opened this issue Sep 28, 2018 · 7 comments · Fixed by #3136
Closed

"Three-dots" menu item is in the wrong place #3076

mogul opened this issue Sep 28, 2018 · 7 comments · Fixed by #3136

Comments

@mogul
Copy link
Contributor

mogul commented Sep 28, 2018

As a user, I want the scope of actions I can take in the UI to be clear by their placement.

Expected behaviour

GIVEN I am looking at any page in Stratos
THEN global actions are available in a location outside the content specific to that page.

Actual behaviour

GIVEN I am looking at any page in Stratos
THEN the "three-dots" menu (About, Profile, Logout) is inside the content that is specific to that page.

image

@mogul
Copy link
Contributor Author

mogul commented Sep 28, 2018

In case the image isn't clear: The location of the three-dots menu in the blue bar implies that it is subordinate to the Applications container in the information hierarchy of the page, when it is not.

@KlapTrap
Copy link
Contributor

KlapTrap commented Oct 3, 2018

It is common practice to put the user menu bar in the top right of the screen, especially when following the material design spec - see google docs or gmail as examples. Moving the menu would deviate from what a user would likely expect and would have seen in other similar applications.

Another solution to the problem could be to better separate the user menu from the contextual action buttons, similar to how kube dashboard does it here. What do you think @mogul?

@richard-cox
Copy link
Contributor

I'd agree that this does appear a bit muddled together, we should do a better job of differentiating the two areas.

@mogul
Copy link
Contributor Author

mogul commented Oct 10, 2018

@KlapTrap The kube dashboard has the user menu in the white global navbar at the top, so it's clear that the menu has nothing to do with what is under Overview in the hierarchy of "stuff on the page".
If the kube dashboard included the user menu icon in the blue Overview bar, I'd have filed a similar issue with them. :) The equivalent of kube's global white navbar in Stratos is that black area to the left, which is why I suggested moving the user menu there.

Also IIRC the "three-dots" menu in material design connotes "there're more actions available on this thing than we felt warranted (or could fit) icons in this space; touch here for the overflow". Given the placement, we would expect that the overflow content would be "more actions related to Applications. So in addition to moving the menu, I'd make the icon something more like what kube uses for making it clear it's stuff related to the user, rather than three-dots.

@mogul
Copy link
Contributor Author

mogul commented Oct 10, 2018

Looked it up just to be sure... Here is the doc about the three-dots menu being for actions overflow (search for Action items and overflow menu (optional) and see the animation under Nesting Actions > Action Positioning).

@KlapTrap
Copy link
Contributor

I was aware that the docs that the three dots are often used for overflow actions, but we were at a bit of a loss as to which other icon to use that didn't just look like another action, or didn't clash with an icon we already used. The three dots are often synonyms with "there is a menu under this button" so we stuck with that but I completely understand the confusion it causes.

Considering everything here I think we should:

  1. Ensure there is an obvious split between contextual actions and the "user menu"
    Possibly a subtle vertical line?

  2. Use an more appropriate icon.
    Maybe follow the google pattern of the first letter of the username in a circle? As seen here in chrome

screen shot 2018-10-16 at 09 58 34

Does that sound good @mogul ?

@mogul
Copy link
Contributor Author

mogul commented Oct 16, 2018

I still feel like that resulting "person" icon+menu belongs higher in the page/div hierarchy so it's not "within" [Apps|Marketplace|Services|CloudFoundry].

However, what you're suggesting would be an incremental improvement, so go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants