Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/uaa page is still available in a configured system #3056

Closed
richard-cox opened this issue Sep 24, 2018 · 3 comments · Fixed by #3768
Closed

/uaa page is still available in a configured system #3056

richard-cox opened this issue Sep 24, 2018 · 3 comments · Fixed by #3768
Assignees
Labels

Comments

@richard-cox
Copy link
Contributor

richard-cox commented Sep 24, 2018

  • the setup endpoints will error if the config is there, however user can still access /uaa
  • need to disable route or redirect to /
@nwmac nwmac self-assigned this Jun 12, 2019
@brittag
Copy link

brittag commented Jul 17, 2019

I noticed that this issue is similar to #3598 and this one is older, so I'm adding a comment here.

My team noticed this issue in this issue backlog, and we believe this is important to fix for good "defense in depth" security practices - it's important to not expose any extra functionality that does not need to be exposed. Even if this current /uaa page returns an error if an attacker tries to input alternate configuration, it's still a serious potential vulnerability because another bug could come up that enabled them to submit real information and alter the system.

So we would encourage prioritizing this issue and considering any other place in Stratos where unnecessary functionality is exposed. Happy to provide further comments or ideas if helpful. Thank you!

(cc @nwmac since you self-assigned this recently)

@richard-cox
Copy link
Contributor Author

Hi @brittag, thanks for commenting. We'll look into this in our next sprint (due to start next week)

@brittag
Copy link

brittag commented Jul 18, 2019

Thank you @richard-cox, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants