@nwmac - looks good.

A few issues I found when running the script on Ubuntu:

git rm src/jetstream/app-core should be rmdir src/jetstream/app-core (as it's an empty dir, and not stored in git, and gives an error when running)
The sed -i '' seemed to need to be sed -i'' on Ubuntu
The 3 import search and replaces can be simplified to 2:

# Fix logrus imports to match capitalization used by the CF CLI library (else dep will fail)
find . -name "*.go" | xargs sed -i'' 's/github.com\/Sirupsen\/logrus/github.com\/sirupsen\/logrus/g'

# Update imports
find . -name "*.go" | xargs sed -i'' 's/github.com\/SUSE\/stratos-ui/github.com\/cloudfoundry-incubator\/stratos\/src\/jetstream/g'

But at the end, the binary builds in a standard GOPATH, which is great!

I've seen projects go both ways with respect to committing the vendor dir... The nice thing about dep is that it prunes tests and unused packages by default, so the vendor dir tends to be much smaller than those produced by Glide in my experience.

Investigate Go Modules or other solutions for refactoring Backend plugins #2815

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions