Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate endpoint id from hash of url, rather than random guid #2798

Closed
richard-cox opened this issue Aug 7, 2018 · 0 comments
Closed

Generate endpoint id from hash of url, rather than random guid #2798

richard-cox opened this issue Aug 7, 2018 · 0 comments

Comments

@richard-cox
Copy link
Contributor

richard-cox commented Aug 7, 2018

Suggested by @andrewghobrial

What do you all think of using the hash of endpoint URL to generate cnsi id in cnsi.go instead of a random guid? The benefit of this is that we can generate a link to application in stratos without having to lookup the endpoint guid. Also endpoint guids right now change every time you reinstall stratos or delete endpiont..

This seems like a really good idea and opens up a whole world of bookmark possibilities.
In terms of the frontend I think we're pretty agnostic to whatever the id is, however it should remain a string and some param names contain guid (not a deal breaker).
@irfanhabib Is there anything backend wise that changing this format might bring up?
Also, wondering if there's anywhere in v2 where we exploit same url endpoints (think in v1 we did something for e2e tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant