Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination request: Validation doesn't insert correct value into store #2684

Closed
KlapTrap opened this issue Jul 18, 2018 · 0 comments
Closed

Comments

@KlapTrap
Copy link
Contributor

When we receive no results for a pagination request we don't fill out the store correctly. Are there any other issues that may come from this?

Example

Api Response

{
...
resources: []
total_pages: 1,
total_results: 1
}

What ends up in the store pagination section:

{
...
ids: {}
...
}

Expected:

``
{
...
ids: { 1: [] }
...
}

richard-cox added a commit that referenced this issue Jul 18, 2018
- ids: { } => ids: { 1: [] }
- think this is a regression following the removal of partial entities
- Fixes #2682, #2684
KlapTrap added a commit that referenced this issue Jul 19, 2018
* v2-master: (101 commits)
  More tidy up
  Tidied up some code
  linting fix
  Tweaks as per discussion, also upped page size from 50 to 100 for permissions fetch
  Fix tests
  Linting
  Flatten pagination for current user permission fetching
  Ensure lists with no entities populate pagination section correctly - ids: { } => ids: { 1: [] } - think this is a regression following the removal of partial entities - Fixes #2682, #2684
  Make flattenPagination generic
  Add note about memory usage
  Clean up whitespace
  Ensure we don't worry about empty page request infos if we already have is list
  Fix for add org button vanishing
  Fix unit tests
  Fix cc
  Improve styling of new chips button
  Fix click action interferring with scroll bar
  Minor tidy ups
  Use subtle mode by default for the boolean indicator
  Add support for new SCF Config LB property
  ...
irfanhabib pushed a commit that referenced this issue Jul 19, 2018
- ids: { } => ids: { 1: [] }
- think this is a regression following the removal of partial entities
- Fixes #2682, #2684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants