Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org Summary shows wrong space count after deleting a space #2046

Closed
richard-cox opened this issue Apr 17, 2018 · 1 comment
Closed

Org Summary shows wrong space count after deleting a space #2046

richard-cox opened this issue Apr 17, 2018 · 1 comment
Assignees
@nwmac @richard-cox
Labels
bug P1 Priority 1

Comments

@richard-cox
Copy link
Contributor

  • Entity Service fails to emit changes to the org enity after the org-space reducer edit's the org's space list
  • The service only emits changes to the entity after the entity's request state changes
private getEntityObservable = (
    entityMonitor: EntityMonitor<T>,
    actionDispatch: Function
  ): Observable<EntityInfo> => {
    return entityMonitor.entityRequest$
      .withLatestFrom(entityMonitor.entity$)

I don't think we should blindly change this to combineLatest. Could try and put an updated timestamp in the request object update section?
@nwmac nwmac added V2 and removed V2 labels May 3, 2018
@nwmac nwmac added the P1 Priority 1 label Jun 12, 2018
@nwmac nwmac self-assigned this Jun 19, 2018
@nwmac
Copy link
Contributor

nwmac commented Jun 19, 2018

If you delete from the space page itself then it works as expected. Deleting from the space card on the org summary does not update the count.

This was referenced Jun 20, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwmac nwmac

@richard-cox richard-cox

Labels
bug P1 Priority 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nwmac @richard-cox