Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy application: Enable deploying from private Git repositories #1442

Closed
1 of 5 tasks
CAFxX opened this issue Jan 22, 2018 · 7 comments
Closed
1 of 5 tasks

Deploy application: Enable deploying from private Git repositories #1442

CAFxX opened this issue Jan 22, 2018 · 7 comments
Labels
community Community Raised Issue feature-request

Comments

@CAFxX
Copy link

CAFxX commented Jan 22, 2018

Deployment type

(select the type below by replacing the space with an x)

  • Cloud Foundry Application (cf push)
  • Kubernetes, using a helm chart
  • Docker, using docker compose
  • Docker, single container deploying all components
  • Other (please provide below)

Expected behaviour

  • As a UI user I want to be able to deploy an application contained in a Git repository that requires authentication (username and password explicitly provided by the user)
  • As a UI user I want to be able to deploy an application contained in a Git repository that requires authentication (username and password of the currently logged-in user)

Actual behaviour

  • As a UI user I can deploy only applications contained in a public Git repository (i.e. a repository with no authentication)

Steps to reproduce the behavior

  • Click on "deploy application"
  • Notice that the only supported options are "deploy from public github repo", "deploy from public Git repo" and "deploy from local folder/file"

Detailed Description

The deploy application UI should allow users to (optionally) specify the credentials to use when authenticating to the remote Git repository. The UI should then use these credentials when pulling the repository.

Context

In corporate environments most repositories require authentication.

Possible Implementation
@richard-cox
Copy link
Contributor

This is a good request. We previously had a pretty decent method to manage github tokens via the endpoints page. Ideally we'd like to bring this method back in and use it to support deploy.
Once we've tackled feature comparity for deploy in V2 (which should hopefully appear in this repo this week) we'd like to tackle this one.

@richard-cox richard-cox mentioned this issue Jan 24, 2018
Open
@richard-cox richard-cox changed the title Enable deploying from private Git repositories Deploy application: Enable deploying from private Git repositories Jan 24, 2018
@nwmac nwmac added the V1 label Jan 31, 2018
@richard-cox richard-cox mentioned this issue Mar 22, 2018
Closed
@nwmac nwmac added the V2-next label Jun 6, 2018
@XuejiaoZhang
Copy link

@richard-cox It would be very helpful if it's possible to deploy from private Git repositories. I am looking forward to it.

@giner
Copy link

giner commented Jul 19, 2018

This actually works now if you specify url with credentials like https://user:pass@git.domain.com/myrepo.git however URL together with credentials will be passed to Stratos application logs. It would be nice to have this improved.

@KlapTrap
Copy link
Contributor

@XuejiaoZhang @giner We're working to get a v1 release out at the moment but once we're finished (hopefully within the next couple of weeks) we'll get on this issue, it's a high priority for us.

@KlapTrap KlapTrap removed the V2-next label Aug 22, 2018
@richard-cox richard-cox added the community Community Raised Issue label Oct 24, 2018
@nwmac
Copy link
Contributor

nwmac commented Jun 13, 2019

Should also cover GitLab

@nwmac nwmac mentioned this issue Jun 13, 2019
Closed
@kreinecke kreinecke added the triage Requires review of inportance and prioritisation label Jun 24, 2019
@kreinecke kreinecke removed the triage Requires review of inportance and prioritisation label Aug 2, 2019
@richard-cox
Copy link
Contributor

This will be possible when #4293 is fixed, though it's not currently planned in the near term.

@richard-cox richard-cox mentioned this issue Nov 26, 2020
Merged
@nwmac
Copy link
Contributor

nwmac commented Jan 23, 2021

Fixed in latest version 4.4.0

@nwmac nwmac closed this as completed Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Community Raised Issue feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@CAFxX @giner @nwmac @KlapTrap @XuejiaoZhang @richard-cox @kreinecke