Remove as'd typings from the cf entity generator

cloudfoundry · Sep 4, 2019 · b9da90f · b9da90f
1 parent 307d71a
commit b9da90f
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/src/frontend/packages/cloud-foundry/src/cf-entity-generator.ts b/src/frontend/packages/cloud-foundry/src/cf-entity-generator.ts
@@ -215,7 +215,7 @@ function generateCFQuotaDefinitionEntity(endpointDefinition: StratosEndpointExte
 }
 
 function generateCFAppEnvVarEntity(endpointDefinition: StratosEndpointExtensionDefinition) {
-  const definition = {
+  const definition: IStratosEntityDefinition<any, APIResource, any> = {
     type: appEnvVarsEntityType,
     schema: cfEntityFactory(appEnvVarsEntityType),
     endpoint: endpointDefinition,
@@ -226,21 +226,21 @@ function generateCFAppEnvVarEntity(endpointDefinition: StratosEndpointExtensionD
       getPaginationParameters: (page: number) => ({ page: '1' })
     },
     successfulRequestDataMapper: (data, endpointGuid, guid, entityType, endpointType, action) => {
-      if (data) {
-        return {
-          entity: {
-            ...data,
-            cfGuid: endpointGuid
-          },
-          metadata: {
-            guid: action.guid
-          }
-        };
-      }
-      return {};
+      return {
+        entity: {
+          ...(data || {}),
+          cfGuid: endpointGuid
+        },
+        metadata: {
+          guid: action.guid,
+          created_at: '',
+          updated_at: '',
+          url: ''
+        }
+      };
     },
     // TODO: we need a envvar type
-  } as IStratosEntityDefinition<any, APIResource, any>;
+  };
   return new StratosCatalogueEntity<IFavoriteMetadata, APIResource>(definition, {
     dataReducers: [
       endpointDisconnectRemoveEntitiesReducer()
@@ -358,7 +358,7 @@ function generateCFUserProvidedServiceInstanceEntity(endpointDefinition: Stratos
 }
 
 function generateCFAppStatsEntity(endpointDefinition: StratosEndpointExtensionDefinition) {
-  const definition = {
+  const definition: IStratosEntityDefinition<any, AppStat> = {
     type: appStatsEntityType,
     schema: cfEntityFactory(appStatsEntityType),
     endpoint: endpointDefinition,
@@ -386,7 +386,7 @@ function generateCFAppStatsEntity(endpointDefinition: StratosEndpointExtensionDe
       }
       return data;
     },
-  } as IStratosEntityDefinition<any, AppStat>;
+  };
   return new StratosCatalogueEntity<IFavoriteMetadata, AppStat>(definition, {
     dataReducers: [
       endpointDisconnectRemoveEntitiesReducer()