Remove unused code #4072
Merged
Remove unused code #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethboyles
force-pushed
the
remove-unused-methods
branch
from
3f4c23c to
9e405ee
Compare
sethboyles
force-pushed
the
remove-unused-methods
branch
from
9e405ee to
5f9b92c
Compare
a-b
reviewed
Nov 11, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| module VCAP::CloudController | |||
| class Runner | |||
| attr_reader :config, :config_file, :insert_seed_data, :secrets_file | |||
There was a problem hiding this comment.
Is it possible that this is used by a rake task or pipeline that wasn't loaded into the debride analysis context?
There was a problem hiding this comment.
There's no reference to it in cloud_controller_ng or capi-release. capi-release has references to CCNG's Drain code that debride didn't catch, but as far as I can tell that is the only place CCNG's code is referenced externally (and arguably should be replaced with a rake task)
nookala
approved these changes
Nov 12, 2024
moleske
approved these changes
Dec 16, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Dec 17, 2024
Changes in cloud_controller_ng:
- Remove unused code
PR: cloudfoundry/cloud_controller_ng#4072
Author: Seth Boyles <seth.boyles@broadcom.com>
Dependency updates in cloud_controller_ng:
- build(deps-dev): bump rubocop-rspec from 3.2.0 to 3.3.0
PR: cloudfoundry/cloud_controller_ng#4139
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out this gem debride, which attempts to identify unused code in Ruby.
Due to the dynamic and meta-programmatic nature of Ruby/CCNG, there were a lot of false positives, and these were a few that I believe can safely be removed.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests