Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lifetimes in sendTracesToExportedHandler #3294

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix lifetimes in sendTracesToExportedHandler #3294

merged 1 commit into from
Jan 6, 2025

Conversation

danlapid
Copy link
Collaborator

@danlapid danlapid commented Jan 6, 2025

No description provided.

@danlapid danlapid requested a review from anonrig January 6, 2025 22:51
@danlapid danlapid requested review from a team as code owners January 6, 2025 22:51
@danlapid danlapid requested a review from dom96 January 6, 2025 22:51
anonrig
anonrig approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it easy to add a test to this? (So we don't regress)

@danlapid
Copy link
Collaborator Author

danlapid commented Jan 6, 2025

Is it easy to add a test to this? (So we don't regress)

Not really, that's why we get these so often.

@danlapid danlapid merged commit d8de55a into main Jan 6, 2025
15 checks passed
@danlapid danlapid deleted the dlapid/fix_trace_lifetime branch January 6, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@dom96 dom96 Awaiting requested review from dom96 dom96 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danlapid @anonrig