h3i: add --replay-host-override option #1867
Conversation
h3i/src/recordreplay/qlog.rs
Outdated
| .as_bool() | ||
| .unwrap_or_default(); | ||
|
|
||
| match &value.frame_created.frame { |
There was a problem hiding this comment.
AFAICT this only ever creates one action per H3FrameCreatedEx. We can probably simplify the code by just implementing From<H3FrameCreatedEx> for Action, then when we iterate over the list in actions_from_qlog, we could just create the H3FrameCreatedEx and push it to the action vector directly.
We could slip host_override into the ExData when creating translating the H3FrameCreated -> H3FrameCreatedEx, then map it in the From implementation if the H3FrameCreatedEx contains a Headers frame
|
One thing we could do to test h3i's parser is to add sample qlogs as test data and run the parser against them to ensure they generate the correct actions, and vice versa. Doesn't need to be here, just a thought since it's touching the |
|
Good idea |
One use case for replaying a recorded session with the h3i CLI is to execture the same sequence of actions to different target servers. Many servers will validate that there is a provided "host" or ":authority" header field, and that it matches the certificate SAN. This change adds the "--replay-host-override" option that can be used in combination with the --qlog-input option. It replaces any "host" or ":authority" header in a HEADERS frame, with the provided value.
LPardue
force-pushed
the
h3i-host-override
branch
from
312903d to
2a265cf
Compare
|
I added some simple tests for parsing a qlog with http headers with and without a host_override. Other parts of parsing are already covered in the qlog QlogSeqReader itself |
One use case for replaying a recorded session with the h3i CLI is to execture
the same sequence of actions to different target servers. Many servers will
validate that there is a provided "host" or ":authority" header field, and that
it matches the certificate SAN.
This change adds the "--replay-host-override" option that can be used in
combination with the --qlog-input option. It replaces any "host" or ":authority"
header in a HEADERS frame, with the provided value.
note: the diff looks huge but most of what its doing is swapping a From impl to a function so the host_override value can be passed to the correct place