Flush qlog streamer before closing the connection #1629
Conversation
|
This looks good, but I think it might even better to implement the |
|
Yeah Drop sounds good. |
FranzBusch
force-pushed
the
fb-qlog-flush
branch
2 times, most recently
from
7fd6762 to
08874a9
Compare
|
@ghedo @LPardue I have updated the code to implement |
FranzBusch
force-pushed
the
fb-qlog-flush
branch
3 times, most recently
from
bb2b33e to
20884eb
Compare
quiche/src/lib.rs
Outdated
| qlog_with!(self.qlog, _q, { | ||
| self.qlog.streamer = None; | ||
| }); |
There was a problem hiding this comment.
| qlog_with!(self.qlog, _q, { | |
| self.qlog.streamer = None; | |
| }); | |
| qlog_with!(self.qlog, q, { | |
| q = None; | |
| }); |
this should work
There was a problem hiding this comment.
Thanks! Not writing Rust usually 😉
There was a problem hiding this comment.
Ok sorry that didn't work, my bad. Let me try something else
# Motivation I was debugging some connection problems and enabled qlog; however, often I did not get output. My use-case is going through the FFI layer which instantiates a `BufferedWriter` for the file. After looking through the code a bit it appears that the `QLogStreamer` is not flushed on all close paths which can lead to missing logs. # Modification Make sure that on every close path the streamer is flushed and closed as well.
FranzBusch
force-pushed
the
fb-qlog-flush
branch
from
20884eb to
5a97133
Compare
Motivation
I was debugging some connection problems and enabled qlog; however, often I did not get output. My use-case is going through the FFI layer which instantiates a
BufferedWriterfor the file. After looking through the code a bit it appears that theQLogStreameris not flushed on all close paths which can lead to missing logs.Modification
Make sure that on every close path the streamer is flushed and closed as well.