Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.14 in CI #881

Merged
merged 2 commits into from
May 8, 2020
Merged

Upgrade to Go 1.14 in CI #881

merged 2 commits into from
May 8, 2020

Conversation

mislav
Copy link
Contributor

@mislav mislav commented May 7, 2020

This ensures that we're testing against and compiling binaries for releases using the newest version of Go.

Ref. #514

@mislav mislav requested review from vilmibm and probablycorey May 8, 2020 10:06
@mislav
Copy link
Contributor Author

mislav commented May 8, 2020

This didn't seem to help with the TLS handshake issue, but it might still be a worthwhile thing to do.

Update: we should definitely bump our Go version again once this gets released golang/go@6f52790. It looks like it will solve these issues for macOS users who download our precompiled binaries.

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested gh against go 1.14 on windows the other day and things were peachy, so A+

@vilmibm vilmibm merged commit 27de1fd into master May 8, 2020
@mislav mislav deleted the go1.14 branch May 11, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants