-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR template added and gitignore improved #867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for review
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 65 65
Lines 5091 5091
Branches 875 875
=======================================
Hits 4923 4923
Misses 86 86
Partials 82 82 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR template LGTM.
@elisno will let you make suggestions for the .gitignore based on your preferences and merge this.
Co-authored-by: Jonas Mueller <1390638+jwmueller@users.noreply.github.com>
This is a great template! As part of the summary/impact, could we also suggest adding screenshots when there is a change in documentation/rendered notebooks? Example - #751. |
@elisno, this is pretty simple PR. It may be nice to merge this soon, so others would be able to start using the template and gitignore soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @smttsp!
- The .gitignore looks pretty good to me.
- I made a few suggestions on what to change about the PR template.
Co-authored-by: Elías Snorrason <eliassno@gmail.com>
Co-authored-by: Elías Snorrason <eliassno@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix spacings and update the clean vision pr template as well once we finalize this
- Enhance instructions for PR purpose and usage examples. - Add clear, user-friendly placeholders for contributors. - Ensure code snippets are executable and demonstrative. - Fix formatting of remaining sections
@elisno, I am fine with the changes. I think the next step will be that you will take over the branch and merge it, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution @smttsp!
Summary
This PR adds a
PR template
to thecleanlab
repo (as seen in this PR) as well as adds some extensions/folders to.gitignore
to make it more comprehensive.Impact
Testing
Ticket(s) or Conversations
References