Improve indexing for Object Detection Badloc Score #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
This reverts commit cc0fb47.
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 64 64
Lines 4888 4889 +1
Branches 844 844
=======================================
+ Hits 4722 4723 +1
Misses 85 85
Partials 81 81
|
jwmueller
reviewed
Aug 12, 2023
| prediction[3][1][-1] = low_prob # artificially set low probability for box in class. 1 < 2 | ||
| label = copy.deepcopy(labels[0]) | ||
| _ = compute_badloc_box_scores(labels=[label], predictions=[prediction]) | ||
|
|
There was a problem hiding this comment.
there's nothing to be asserted in this test?
There was a problem hiding this comment.
are you sure there doesn't need to be analogous unit tests for the swap / overlook issue subtypes?
tataganesh
pushed a commit
to tataganesh/cleanlab
that referenced
this pull request
Aug 16, 2023
tataganesh
pushed a commit
to tataganesh/cleanlab
that referenced
this pull request
Aug 16, 2023
ulya-tkch
added a commit
to ulya-tkch/cleanlab
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #806