Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation docs fix #775

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Segmentation docs fix #775

merged 5 commits into from
Jul 14, 2023

Conversation

elisno
Copy link
Member

@elisno elisno commented Jul 14, 2023

  • Some internal links were broken. Should be fixed now.

  • Use special block for tips:

image

  • Format class_names example as a code block:
    image

  • Put note in a block
    image

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches! Just had one suggestion but go ahead and merge after considering it

Co-authored-by: Jonas Mueller <1390638+jwmueller@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #775 (511fca0) into master (e2d413a) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 511fca0 differs from pull request most recent head 8b914dc. Consider uploading reports for the commit 8b914dc to get more accurate results

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   96.44%   96.23%   -0.22%     
==========================================
  Files          60       60              
  Lines        4726     4726              
  Branches      823      823              
==========================================
- Hits         4558     4548      -10     
- Misses         87       93       +6     
- Partials       81       85       +4     
Impacted Files Coverage Δ
cleanlab/segmentation/filter.py 100.00% <ø> (ø)
cleanlab/segmentation/rank.py 96.15% <ø> (ø)
cleanlab/segmentation/summary.py 98.03% <ø> (ø)

... and 1 file with indirect coverage changes

@elisno elisno merged commit 063c0fe into cleanlab:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants