Fixed bug that shows warning message even after specifying estimation… #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_method = 'off_calibrated_custom'
|
|
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 51 51
Lines 4168 4168
Branches 729 729
=======================================
Hits 4010 4010
Misses 85 85
Partials 73 73
|
jwmueller
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_method = 'off_calibrated_custom'
The warning message that says 'confident_joint' will be recomputed shows up even after specifying estimation_method = "off_calibrated_custom". Also, "off_calibrated_custom" is missing from the list of valid methods.