Improve visualize function for object detection #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ulya-tkch
commented
Jun 7, 2023
ulya-tkch
commented
- fix linestyle when overlay=False
- add option to save image as different types of files
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 96.15% 96.20% +0.04%
==========================================
Files 51 51
Lines 4163 4165 +2
Branches 729 728 -1
==========================================
+ Hits 4003 4007 +4
+ Misses 86 85 -1
+ Partials 74 73 -1
|
huiwengoh
reviewed
Jun 8, 2023
| image_format = ( | ||
| save_path[-3:] | ||
| if len(save_path) > 2 | ||
| and save_path[-4] == "." |
There was a problem hiding this comment.
I believe this check will fail for filename.ps since save_path[-4] != "."
Would it instead be better to use save_path.split(".")? Tho you might need some try-except blocks to catch in case the path provided does not contain a period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.