Make labels optional in Datalab #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 96.18% 96.00% -0.19%
==========================================
Files 46 46
Lines 3645 3702 +57
Branches 650 655 +5
==========================================
+ Hits 3506 3554 +48
- Misses 73 81 +8
- Partials 66 67 +1
|
sanjanag
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we make the
label_nameargument optional in the constructor ofDatalab.Some label logic (that used to reside in the
Dataclass) has been extracted to a newLabelclass (working title). I didn't bother to move it to a separate module (as it's only used by theDataclass for now).A new test class has been added, where we start testing Datalab instances with no labels.