Fix unbound knn variable in NonIIDIssueManager #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it won't be defined if a pre-existing knn graph is found during the non-iid issue check.
elisno
changed the title
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 95.77% 95.86% +0.08%
==========================================
Files 46 46
Lines 3648 3649 +1
Branches 651 651
==========================================
+ Hits 3494 3498 +4
Misses 79 79
+ Partials 75 72 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR really just fixed one bug where the
knnobject isn't set within the NonIIDIssuemanager if aknn_graphis already accessible.It's a simple as just initializing the parameter to None. That's already the expected type for
knnwhen just theknn_graphis used.Along with this change, I've added some end-to-end tests in Datalab that ensure the summary is updated appropriately with incremental search.
That's how the
knnbug was discovered in the first place, because the IssueManagers would otherwise fail silently when callingDatalab.find_issues.