Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename get_summary -> get_issue_summary for Datalab. #691

Merged
merged 1 commit into from
May 2, 2023

Conversation

elisno
Copy link
Member

@elisno elisno commented May 2, 2023

This only affects Datalab/DataIssues.

Sidenote

IssueManager has a different method with the get_summary name that is used in a different way.

This only pertains to Datalab/DataIssues. IssueManager has a different method with the get_summary name that is used in a different way.

fix: 🔥 remove cleanvision submodule
@elisno elisno force-pushed the get_issue_summary branch from 11d6c3f to 87e9c98 Compare May 2, 2023 19:11
@elisno elisno requested review from jwmueller and sanjanag May 2, 2023 19:11
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #691 (11d6c3f) into master (e33b757) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

❗ Current head 11d6c3f differs from pull request most recent head 87e9c98. Consider uploading reports for the commit 87e9c98 to get more accurate results

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   95.79%   95.51%   -0.28%     
==========================================
  Files          46       46              
  Lines        3638     3638              
  Branches      649      649              
==========================================
- Hits         3485     3475      -10     
- Misses         79       85       +6     
- Partials       74       78       +4     
Impacted Files Coverage Δ
cleanlab/datalab/report.py 96.29% <ø> (ø)
cleanlab/datalab/data_issues.py 98.55% <100.00%> (ø)
cleanlab/datalab/datalab.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@elisno elisno merged commit f8b11d3 into cleanlab:master May 2, 2023
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Unrelated to this PR, I noticed get_summary still exists in the code of custom_issue_manager.rst, and no longer seems to be an instance method, so that probably needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants