Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation #677

Merged
merged 99 commits into from
Jun 23, 2023
Merged

Segmentation #677

merged 99 commits into from
Jun 23, 2023

Conversation

vdlad
Copy link
Contributor

@vdlad vdlad commented Apr 24, 2023 •
edited by jwmueller
Loading

Addition of segmentation functionality to cleanlab.

Closes: #376, #586

@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Merging #677 (ba4f57a) into master (860bd6f) will increase coverage by 0.10%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   96.20%   96.31%   +0.10%     
==========================================
  Files          51       56       +5     
  Lines        4168     4392     +224     
  Branches      729      768      +39     
==========================================
+ Hits         4010     4230     +220     
  Misses         85       85              
- Partials       73       77       +4
Impacted Files Coverage Δ
cleanlab/segmentation/rank.py 96.15% <96.15%> (ø)
cleanlab/segmentation/summary.py 98.03% <98.03%> (ø)
cleanlab/__init__.py 100.00% <100.00%> (ø)
cleanlab/internal/segmentation_utils.py 100.00% <100.00%> (ø)
cleanlab/segmentation/__init__.py 100.00% <100.00%> (ø)
cleanlab/segmentation/filter.py 100.00% <100.00%> (ø)

@ulya-tkch
Copy link
Contributor

ulya-tkch commented May 5, 2023 •
edited
Loading

  • Make sure you add the files into appropriate cleanlab/docs/source/ folders for the docstrings can build.
  • Check docstring build looks good and links work.
  • Add single line function headers explaining what the function is for for each internal function. Make each internal function function() -> _function()

@ulya-tkch
Copy link
Contributor

ulya-tkch commented May 5, 2023 •
edited
Loading

Get this code to pass the CI:

  • call black cleanlab
  • remove unused imports
  • run mypy cleanlab/segmentation and make sure it passes typecheck
  • add unit tests to up codecov

ulya-tkch
ulya-tkch reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@ulya-tkch ulya-tkch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make all optional arguments kwargs

@ulya-tkch ulya-tkch requested review from sanjanag and jwmueller June 14, 2023 23:56
jwmueller
jwmueller reviewed Jun 15, 2023
View reviewed changes
cleanlab/segmentation/summary.py Outdated
num_classes = max(np.unique(labels)) + 1
cmap = _generate_colormap(num_classes)
else:
cmap = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it concerning this line is never tested? If not, then just leave as is, hard for me to tell

jwmueller
jwmueller approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Just had two minor remaining comments related to codecov which @ulya-tkch can address easily. Ping me to handle merge of this then

Thanks for your hard work on this @vdlad @ulya-tkch !!

@jwmueller jwmueller merged commit 35606fc into cleanlab:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulya-tkch ulya-tkch ulya-tkch left review comments

@jwmueller jwmueller jwmueller approved these changes

@sanjanag sanjanag Awaiting requested review from sanjanag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Image Semantic Segmentation
3 participants
@vdlad @ulya-tkch @jwmueller