Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text and tabular tutorial #673

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Update text and tabular tutorial #673

merged 7 commits into from
Apr 27, 2023

Conversation

huiwengoh
Copy link
Contributor

@huiwengoh huiwengoh commented Apr 21, 2023 •
edited
Loading

Text tutorial:

  • changed the dataset from IMDB reviews to Banking77-OOS
  • changed the existing tf vectorizer + keras model to sentence-transformers for extracting embeddings and a logreg model for training

Tabular tutorial:

  • changed the dataset from German Credit to student grades

@huiwengoh huiwengoh requested a review from jwmueller April 21, 2023 02:54
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Merging #673 (034f196) into master (6353e54) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 034f196 differs from pull request most recent head 2abee64. Consider uploading reports for the commit 2abee64 to get more accurate results

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   95.82%   95.88%   +0.06%     
==========================================
  Files          46       32      -14     
  Lines        3639     2652     -987     
  Branches      649      527     -122     
==========================================
- Hits         3487     2543     -944     
+ Misses         79       60      -19     
+ Partials       73       49      -24

see 15 files with indirect coverage changes

@huiwengoh huiwengoh changed the title Update text tutorial Update text and tabular tutorial Apr 21, 2023
jwmueller
jwmueller approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! I just had minor comments but it's good to go after you address those

@huiwengoh huiwengoh merged commit 9c32337 into cleanlab:master Apr 27, 2023
@huiwengoh huiwengoh deleted the text-tutorial-banking branch May 19, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwmueller jwmueller jwmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huiwengoh @jwmueller