Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Studio References #1182

Merged
merged 14 commits into from
Aug 2, 2024
Merged

Update Studio References #1182

merged 14 commits into from
Aug 2, 2024

Conversation

nelsonauner
Copy link
Contributor

No description provided.

@nelsonauner nelsonauner requested a review from jwmueller August 2, 2024 18:16
@jwmueller
Copy link
Member

jwmueller commented Aug 2, 2024

@nelsonauner could you make the CI pass?

Actually nevermind I'm on it, but would be good if you can look at the CI status in future PRs and call out the issues you're not sure how to resolve:

Screen Shot 2024-08-02 at 2 09 36 PM

Screen Shot 2024-08-02 at 2 09 54 PM

Screen Shot 2024-08-02 at 2 10 40 PM

@jwmueller jwmueller self-requested a review August 2, 2024 21:11
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll oversee the merge of this once CI passes, since some of the issues may not be clear to you.

Once this PR is merged:
Just look back on my commit history to learn how to fix various CI complaints in the future, and then also review the live docs site with these changes (developer version of the docs):

https://docs.cleanlab.ai/master/

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (e4be990) to head (a0f6d7e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
+ Coverage   96.63%   96.67%   +0.04%     
==========================================
  Files          81       81              
  Lines        5935     6053     +118     
  Branches     1021      977      -44     
==========================================
+ Hits         5735     5852     +117     
  Misses        110      110              
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwmueller jwmueller merged commit b699edd into master Aug 2, 2024
28 of 39 checks passed
@jwmueller jwmueller deleted the studio-references-in-tutorials branch August 2, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants