-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit data fn expansion cell formatting #1177
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 96.63% 96.70% +0.07%
==========================================
Files 81 81
Lines 5935 5940 +5
Branches 1021 954 -67
==========================================
+ Hits 5735 5744 +9
+ Misses 110 108 -2
+ Partials 90 88 -2 ☔ View full report in Codecov by Sentry. |
" ```python\n", | ||
" # Note: This pulldown content is for docs.cleanlab.ai, if running on local Jupyter or Colab, please ignore it.\n", | ||
"```python\n", | ||
"# Note: This pulldown content is for docs.cleanlab.ai, if running on local Jupyter or Colab, please ignore it.\n", | ||
" \n", | ||
" def edit_data(train_features, train_labels, label_issues, near_duplicates, outliers, drop_label_issue, drop_near_duplicate, drop_outlier):\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mturk24 why is this other part all still indented?
And where is your screenshot showing how this fixed the docs build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can review this, no need for Elias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird i'm not sure what happened there
Confirming the latest commit has the fix when building docs locally @jwmueller and has the indentation fix |
Co-authored-by: Jonas Mueller <1390638+jwmueller@users.noreply.github.com>
Summary
Quick fix to cell that shows expansion of edit_data function to make Python function render properly in docs. Screenshot shows what current docs show: https://docs.cleanlab.ai/master/tutorials/improving_ml_performance.html