Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1044] Added end-to-end tests at the end of Quickstart editorial #1118

Merged
merged 8 commits into from
May 14, 2024
Merged

[1044] Added end-to-end tests at the end of Quickstart editorial #1118

merged 8 commits into from
May 14, 2024

Conversation

allincowell
Copy link
Contributor

@allincowell allincowell commented May 4, 2024 •
edited by elisno
Loading

Summary

🎯 Purpose: Added end-to-end tests in terms of assert statements for the issue: #1044

Reviewer Notes

💡 In the case of jaccard similarity for label indices, I reduced the threshold to 0.4 instead of 0.9. All other thresholds are set to 0.9.

@CLAassistant
Copy link

CLAassistant commented May 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented May 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (94b9945) to head (afaeccd).
Report is 11 commits behind head on master.

❗ Current head afaeccd differs from pull request most recent head 05cd97e. Consider uploading reports for the commit 05cd97e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1118      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.04%     
==========================================
  Files          76       76              
  Lines        6015     6088      +73     
  Branches     1068     1081      +13     
==========================================
+ Hits         5780     5853      +73     
- Misses        139      141       +2     
+ Partials       96       94       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elisno
elisno approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@elisno elisno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elisno elisno merged commit 2870e19 into cleanlab:master May 14, 2024
19 checks passed
@elisno elisno mentioned this pull request Jun 17, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisno elisno elisno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allincowell @CLAassistant @elisno