Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifications to datalab documentation #1010

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

jwmueller
Copy link
Member

also removed all the Note in the docs about wrappers. I don't see why users would be interested in those docs, they seem potentially confusing and seem oriented to developers. But a developer can just immediately see when a method is a wrapper based on its source code.

@jwmueller jwmueller requested a review from elisno February 14, 2024 18:55
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79b16e6) 96.22% compared to head (8a397bc) 96.05%.

❗ Current head 8a397bc differs from pull request most recent head c3725a2. Consider uploading reports for the commit c3725a2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   96.22%   96.05%   -0.18%     
==========================================
  Files          74       74              
  Lines        5803     5803              
  Branches     1037     1037              
==========================================
- Hits         5584     5574      -10     
- Misses        130      136       +6     
- Partials       89       93       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elisno elisno merged commit 2756d48 into master Feb 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants