Skip to content

Widget definition insert method should include editor instance and command data #2253

Closed
@mlewand

Description

Type of report

Feature request

Provide description of the new feature

As requested in the #235 PR, currently widgetDefinition.insert doesn't feature neither editor nor commandData passed to the command that caused the insert method call.

While editor issue could be mitigated, by storing editor variable as a local variable in the scope, and passing it later on, same can not happen for commandData.

Adding options object to the API that would provide editor and commandData will solve this problem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    changelog:apiA changelog entry should be put in the API section of the changelog.good first issueRelatively easy to fix. This is a perfect issue if you are willing to create a Pull Request.plugin:widgetThe plugin which probably causes the issue.status:confirmedAn issue confirmed by the development team.target:majorAny docs related issue that should be merged into a major branch.type:featureA feature request.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions