Skip to content

Fix memory leaks caused by CKEDITOR.filter.instances storing nested editables' filters forever #1722

Closed
@jswiderski

Description

Are you reporting a feature request or a bug?

Bug

References

Provide detailed reproduction steps (if any)

Every nested editable which has allowed content rules defined has its filter instance. These instances are stored in nested editable instances, which most likely are correctly garbage collected. But filter instances are also stored in CKEDITOR.filter.instances and they are kept there forever.

We could have filter.destroy() method removing instance from the instances hash and doing other cleanup if necessary. Then we could destroy filters when destroying widgets.

Expected result

All filter instances should be removed.

Actual result

Filter instances are also stored in CKEDITOR.filter.instances and they are kept there forever.

Other details

  • Browser: …
  • OS: …
  • CKEditor version: 4.3.0+
  • Installed CKEditor plugins: …

Metadata

Assignees

No one assigned

    Labels

    status:confirmedAn issue confirmed by the development team.supportAn issue reported by a commercially licensed client.target:minorAny docs related issue that can be merged into a master or major branch.type:bugA bug.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions