Fix record-ref reduction in cp0 #421
Merged
+153
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the bug report and fix, which looks correct. Please pull the common Were you able to come up with a mat for the second of the two cases that were missing the There are always things an extra pass of cp0 will pick up. My guess is cases like this aren't particularly common, and it takes only one or two calls to cp0 to when the field is immutable. |
In expressions like (record-ref ... (begin (newline) (record ...))) the reduction was dropping the possible side effect expressions in this case the (newline). cp0.ss
gus-massa
force-pushed
the
19-4-Fix-Record-Ref
branch
from
382b035 to
5c50c5d
Compare
|
Done. I also changed in the test two |
|
Looks good, thanks. |
mflatt
pushed a commit
to racket/ChezScheme
that referenced
this pull request
Mar 24, 2021
Fix record-ref reduction in cp0
mflatt
pushed a commit
to mflatt/ChezScheme
that referenced
this pull request
Oct 10, 2023
Fix record-ref reduction in cp0 Original commit: 53d09d9
mflatt
pushed a commit
to mflatt/ChezScheme
that referenced
this pull request
Oct 10, 2023
Fix record-ref reduction in cp0 Original commit: 53d09d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In expressions like
the current reduction was dropping the possible side effect expressions
in this case the
(newline).A complete example is
==>
2instead of12As a side note, running only two times the cp0 pass, it is not enough to reduce some expressions like
(mybox-val (make-mybox 2))). It is necessary to run cp0 three times. I don't know after expansions and inlining if this kind of pattern is common. I tried compiling with three times cp0 instead of two and the compilation time changes very little. Perhaps it could be useful to change the default.