Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cisagov/ScubaGear
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.0
Choose a base ref
...
head repository: cisagov/ScubaGear
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.1
Choose a head ref
  • 6 commits
  • 49 files changed
  • 4 contributors

Commits on Feb 9, 2024

  1. Fix ProductNames wildcard processing (#886) 

    * Fix ProductNames wildcard processing

* Fix delete test and linter issues

* Set param and bound param

* Fixed reset of scuba config

* Adjudicate comments
    @crutchfield
    crutchfield authored Feb 9, 2024
    Copy the full SHA
    dc92c88 View commit details

  2. Fixes ScubaConfig.LoadConfig repeated invocations (#893) 

    * Added comment-based help string for ScubaConfig

* ScubaConfig: always .ResetInstance before .LoadConfig

* Change type declaration for ScubaConfig.Configuration

* Added unit test for ScubaConfig.LoadConfig corner case

* Megalinter appeasement

* Megalinter gods 🐄🔥

---------

Co-authored-by: Thom Neale <tneale@mitre.org>
    @twneale
    twneale and Thom Neale authored Feb 9, 2024
    Copy the full SHA
    8c8a7e1 View commit details

  3. Remove an unnecessary cmdlet from aad policy check 5.3 to improve per… 

    …formance of the provider (#896)

* WIP

* Update test plan

* Fix 5.3 step 3 instructions
    @crutchfield
    crutchfield authored Feb 9, 2024
    Copy the full SHA
    67bf207 View commit details

Commits on Feb 13, 2024

  1. OPA executable path default value inconsistent between invoke scuba w… 

    …ith or without configfilepath (#894)

* Add defaults

* Back out unintended change

* Update test

* Rename test

* Update tests

* Fix module name in test

* Update function scope

* Update mock in test

* Rework ScubaDefault values
    @crutchfield
    crutchfield authored Feb 13, 2024
    Copy the full SHA
    fe53215 View commit details

Commits on Feb 15, 2024

  1. Allow user to copy sample (read-only) files packaged with module (#862) 

    * Add copy for samples

* Update SmokeTest to check support commands

* Fix linter errors

* Fix linter issues

* Remove hardcoded file names
    @crutchfield
    crutchfield authored Feb 15, 2024
    Copy the full SHA
    c2ae30d View commit details

Commits on Feb 16, 2024

  1. * Pin Microsoft.Graph.* max version to 2.12.0 (#908) 

    * Pin Microsoft.Online.SharePoint.PowerShell to max version 16.0.24322.12000
    @schrolla
    schrolla authored Feb 16, 2024
    Copy the full SHA
    4f2d982 View commit details
Loading