-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak the cilium-dbg preflight migrate-identity command #36089
Merged
tklauser
merged 3 commits into
cilium:main
from
giorio94:mio/fix-preflight-migrate-identities
Nov 22, 2024
Merged
Unbreak the cilium-dbg preflight migrate-identity command #36089
tklauser
merged 3 commits into
cilium:main
from
giorio94:mio/fix-preflight-migrate-identities
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the etcd client is initialized with a context that gets immediately closed once the initialization completed, in turn causing the etcd client to be stopped. Let's fix this by using the parent context, which gets closed only once the migration terminates. Additionally, let's explicitly wait for the client to connect, so that we can return an explicit error in case of problems, rather than failing at a later stage. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The retrieval of node information is not required during the migration of identities, and the current implementation leads to a panic given that the local node store is not initialized. Hence, let's just drop it altogether. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
shutdowner.Shutdown takes a variadic number of parameters, hence let's just omit it. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
This is a bug in the Cilium logic.
area/cli
Impacts the command line interface of any command in the repository.
labels
Nov 21, 2024
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Nov 21, 2024
giorio94
added
the
release-note/bug
This PR fixes an issue in a previous release of Cilium.
label
Nov 21, 2024
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Nov 21, 2024
giorio94
added
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
needs-backport/1.16
This PR / issue needs backporting to the v1.16 branch
labels
Nov 21, 2024
/test |
derailed
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giorio94 Nice work Marco!
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Nov 21, 2024
This was referenced Dec 1, 2024
nbusseneau
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Dec 1, 2024
nbusseneau
added
backport-pending/1.16
The backport for Cilium 1.16.x for this PR is in progress.
and removed
needs-backport/1.16
This PR / issue needs backporting to the v1.16 branch
labels
Dec 1, 2024
1 task
jschwinger233
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Dec 2, 2024
github-actions
bot
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
backport-pending/1.16
The backport for Cilium 1.16.x for this PR is in progress.
labels
Dec 2, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
Impacts the command line interface of any command in the repository.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
kind/bug
This is a bug in the Cilium logic.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit, and refer to the individual messages for additional details.