Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: do not group jobs on merge queues #29551

Merged
merged 1 commit into from
Dec 1, 2023
Merged

.github: do not group jobs on merge queues #29551

merged 1 commit into from
Dec 1, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Dec 1, 2023

During merge queues we don't want to group the concurrent jobs together since they are supposed to run in parallel. Thus, we should suffix the concurrency group with with the github.run_id which is unique per each run but only when the event type is a merge_group.

Concurrent jobs are still canceled for PRs, tested in https://github.com/cilium/cilium/actions/runs/7060613961/job/19220496966?pr=29551

@aanm aanm added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Dec 1, 2023
@aanm aanm requested a review from brlbil December 1, 2023 13:25
@aanm aanm requested review from a team as code owners December 1, 2023 13:25
@aanm aanm force-pushed the pr/fix-merge-queue branch from 65f56c1 to 9064072 Compare December 1, 2023 13:26
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

During merge queues we don't want to group the concurrent jobs together
since they are supposed to run in parallel. Thus, we should suffix the
concurrency group with the `github.run_id` which is unique per each
run but only when the event type is a merge_group.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-merge-queue branch from 9064072 to f9ba4d5 Compare December 1, 2023 13:27
@aanm aanm merged commit 2a8a356 into main Dec 1, 2023
@aanm aanm deleted the pr/fix-merge-queue branch December 1, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants