envoy: periodic version-check with hive timer job #29513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/enhancement
With the introduction of the Envoy DaemonSet mode, the Envoy version check has changed from failing the Cilium Agent at startup to a check that write an error message in case of a version mismatch (or error retrieving the Envoy version). The reason was that the Envoy DaemonSet Pod might not be ready when the Cilium Agent performs the version check. This commit introduces a hive timer job that periodically checks the Envoy version (every 5min). This has the advantage that the version gets checked periodically (in case the daemonset gets deployed with a different version). In addition, any error gets reported via Cilium health reporter. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-periodic-version-check
branch
from
b7f0db6 to
12e8b03
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the Envoy DaemonSet mode, the Envoy version check has changed from failing the Cilium Agent at startup to a check that write an error message in case of a version missmatch (or error retrieving the Envoy version).
The reason was that the Envoy DaemonSet Pod might not be ready when the Cilium Agent performs the version check.
This commit introduces a hive timer job that periodically checks the Envoy version (every 5min (currently hardcoded)). This has the advantage that Envoy version changes during the uptime of the agent are detected (in case the DaemonSet gets deployed with a different version). In addition, any error gets reported via Cilium health reporter.